Re: [Qemu-devel] [PATCH v3 0/6] virtio/vhost cross-endian cleanup

[Greg Kurz]

On Tue, 12 Jan 2016 18:21:05 +0100
Greg Kurz <address@hidden> wrote:

> This series brings some improvements to the cross-endian support in the
> virtio and vhost code:
> - use qemu_set_vnet_be() and qemu_set_vnet_le() directly from virtio-net,
>   so that backend cross-endian capabilities benefit to both emulated and
>   vhost accelerated devices
> - optimize virtio_access_is_big_endian() for little-endian targets
> - various cleanups
> 
> This v3 does the following:
> - fixes spelling mistake in patch 1
> - adds Laurent's R-b tag to patches 1, 2, 3, 5
> - adds Cornelia's R-b tag to patches 1, 5
> - introduces patch 4 to simplify the vhost code a bit more
> 

Laurent Vivier just told me that the current vhost_net code has
a bug with multiqueue+cross-endian. He will send a fix shortly.
Of course the fix conflicts with this series... but since I
believe it is more important, I'll rebase and send a v4 after
Laurent's patch has been applied.

> ---
> 
> Greg Kurz (6):
>       virtio-net: use the backend cross-endian capabilities
>       Revert "vhost-net: tell tap backend about the vnet endianness"
>       virtio: move cross-endian helper to vhost
>       vhost: move virtio 1.0 check to cross-endian helper
>       vhost: simplify vhost_needs_vring_endian()
>       virtio: optimize virtio_access_is_big_endian() for little-endian targets
> 
> 
>  hw/net/vhost_net.c                |   33 +------------------------
>  hw/net/virtio-net.c               |   49 
> +++++++++++++++++++++++++++++++++++--
>  hw/virtio/vhost.c                 |   27 +++++++++++++++++---
>  include/hw/virtio/virtio-access.h |   28 ++-------------------
>  include/hw/virtio/virtio-net.h    |    1 +
>  5 files changed, 75 insertions(+), 63 deletions(-)
> 
>