Re: [Qemu-devel] [PATCH v2] ARM: Virt: Don't generate RTC ACPI device when using UEFI

[Peter Maydell]

On 13 January 2016 at 16:26, Laszlo Ersek <address@hidden> wrote:
> On 01/13/16 17:16, Andrew Jones wrote:
>> On Wed, Jan 13, 2016 at 10:54:17PM +0800, Shannon Zhao wrote:
>>> When booting the VM with UEFI, UEFI takes ownership of the RTC hardware.
>>> While UEFI can use libfdt to disable the RTC device node in the DTB that
>>> it passes to the OS, it cannot modify AML. Therefore, we won't generate
>>> the RTC ACPI device at all when using UEFI.
>>
>> I think a condensed comment similar to this commit message would be nice
>> in build_dsdt, or somewhere. We have a policy for mach-virt of generating
>> ACPI for everything we generate DT. It'd be good if we documented all the
>> divergences in order to avoid confusion. [...]
>
> Good idea!

I'm happy with the code in this patch, so you can add my
Reviewed-by: Peter Maydell <address@hidden>

Shannon, I'm assuming you're planning a v3 with the comment that
Andrew and Laszlo suggest.

thanks
-- PMM