Re: [Qemu-devel] [PULL 00/15] NBD, chardev, SCSI patches for 2015-01-15

[Peter Maydell]

On 15 January 2016 at 16:04, Paolo Bonzini <address@hidden> wrote:
> The following changes since commit f02ccf53693758b65843264e077f90cf295e7d98:
>
>   disas/libvixl: Really suppress gcc 4.6.3 sign-compare warnings (2016-01-14 
> 17:57:51 +0000)
>
> are available in the git repository at:
>
>   git://github.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to 196ab03442304823ee8e7f46bdca49ea6516ebe5:
>
>   qemu-char: do not leak QemuMutex when freeing a character device 
> (2016-01-15 17:03:09 +0100)
>
> ----------------------------------------------------------------
> * qemu-char logfile facility
> * NBD coroutine based negotiation
> * bugfixes

Hi. I'm afraid this fails to build for w32:

target-i386/helper.c: In function ‘x86_cpu_handle_mmu_fault’:
target-i386/helper.c:930: error: ‘PROT_WRITE’ undeclared (first use in
this function)
target-i386/helper.c:930: error: (Each undeclared identifier is
reported only once
target-i386/helper.c:930: error: for each function it appears in.)

Looks like the code intended to use PAGE_WRITE.

thanks
-- PMM