Re: [Qemu-devel] [RFC] util: Fix QEMU_LD_PREFIX endless loop

[Peter Maydell]

On 6 January 2016 at 15:21, Wei-Bo, Chen <address@hidden> wrote:
> Detail bug report in the following url:
> https://bugs.launchpad.net/qemu/+bug/1245703
>
> Remove is_dir_maybe macro condition DT_LNK in util/path.c
>
> Signed-off-by: Wei-Bo, Chen <address@hidden>
> ---
>  util/path.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/path.c b/util/path.c
> index 4e4877e..b99e436 100644
> --- a/util/path.c
> +++ b/util/path.c
> @@ -58,7 +58,7 @@ static struct pathelem *new_entry(const char *root,
>  #if defined(DT_DIR) && defined(DT_UNKNOWN) && defined(DT_LNK)
>  # define dirent_type(dirent) ((dirent)->d_type)
>  # define is_dir_maybe(type) \
> -    ((type) == DT_DIR || (type) == DT_UNKNOWN || (type) == DT_LNK)
> +    ((type) == DT_DIR || (type) == DT_UNKNOWN)
>  #else
>  # define dirent_type(dirent) (1)
>  # define is_dir_maybe(type)  (type)
> --
> 2.5.0

This change would be essentially reverting commit 338d80dd353c50b63,
which specifically added support for symbolic links in the directory
structure. So if we applied it we'd be regressing on the problem
that that change was meant to fix.

Richard, git says that commit was one of yours :-)

thanks
-- PMM