Re: [Qemu-devel] [PATCH v1 1/2] tcg: Add support for constant value promises

[Richard Henderson]

On 01/15/2016 07:35 AM, Lluís Vilanova wrote:
> +TCGv_i64 tcg_promise_i64(TCGv_promise_i64 *promise)
> +{
> +    int pi = tcg_ctx.gen_next_parm_idx;
> +    *promise = (TCGv_promise_i64)&tcg_ctx.gen_opparam_buf[pi];
> +    return tcg_const_i64(0xdeadcafe);
> +}

This doesn't work for a 32-bit host.  The constant may be split across two
different parameter indices, and you don't know exactly where the second will 
be.

Because of that, I think this is over-engineered, and really prefer the simpler
interface that Edgar posted last week.



r~