qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4] linux-user: add signalfd/signalfd4 syscalls


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v4] linux-user: add signalfd/signalfd4 syscalls
Date: Mon, 18 Jan 2016 11:30:41 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0


On 02/10/2015 14:48, Laurent Vivier wrote:
> +        target_fd_trans = g_realloc(target_fd_trans,
> +                                    target_fd_max * sizeof(TargetFdTrans));

This should be TargetFdTrans * (reported by Coverity).  Even better you
could use g_renew.

It's harmless because sizeof(TargetFdTrans) > sizeof(TargetFdTrans *),
but it should be fixed nevertheless.

Paolo

> +        memset((void *)(target_fd_trans + oldmax), 0,
> +               (target_fd_max - oldmax) * sizeof(TargetFdTrans *));



reply via email to

[Prev in Thread] Current Thread [Next in Thread]