[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/pci: ensure that only PCI/PCIe bridges can b
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] hw/pci: ensure that only PCI/PCIe bridges can be attached to pxb/pxb-pcie devices |
Date: |
Mon, 18 Jan 2016 18:27:21 +0000 |
On 18 January 2016 at 18:16, Laszlo Ersek <address@hidden> wrote:
> On 01/18/16 19:08, Peter Maydell wrote:
>> On 18 January 2016 at 15:27, Marcel Apfelbaum <address@hidden> wrote:
>>> PCI devices can't be plugged directly into PCI extra root bridges
>>> because their resources can't be computed by firmware before the ACPI
>>> tables are loaded.
>>>
>>> Signed-off-by: Marcel Apfelbaum <address@hidden>
>>> ---
>>>
>>> Hi,
>>>
>>> This patch follows the discussion:
>>> https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg01484.html
>>
>> Is it definitely the case that no current working command lines plug
>> PCI devices directly into these things (including on platforms that
>> don't have anything to do with ACPI at all) ?
>
> No clue about "pxb-pcie", but re: "pxb", the documentation and examples
> by Marcel (see: "docs/pci_expander_bridge.txt") will certainly continue
> working, with this patch place. And, that text file is authoritative for
> pxb, since Marcel (et al) wrote the code directly for the purposes
> described in the txt.
That may be true, but the patch is changing core code in hw/pci/pci.c
and it's not obvious to me that that's going to be limited to just
pxb or pxb-pcie; so it seemed worth asking.
thanks
-- PMM