Re: [Qemu-devel] [PATCH v2 0/4] set the OEM fields in the RSDT and the FADT from the SLIC

[Steven Newbury]

On Tue Jan 19 07:35:27 2016 GMT, Steven Newbury wrote:
> 
> 
> On Mon Jan 18 14:12:09 2016 GMT, Laszlo Ersek wrote:
> > This is version 2 of
> > <http://thread.gmane.org/gmane.comp.emulators.qemu/386728>.
> > 
> > Changes in v2 (also annotated per patch):
> > - introduce acpi_get_slic_oem() [MST],
> > - drop machine property that disables the SLIC-based override [MST].
> >
> Series looks good to me.  This is much cleaner (less hacky) than the patch I 
> posted. I started out with a similar approach but felt I was being too 
> invasive, so decided to keep it simple.   

For what it's worth:

Reviewed-by: Steven Newbury <address@hidden>

> > Cc: "Michael S. Tsirkin" <address@hidden>
> > Cc: Aleksei Kovura <address@hidden>
> > Cc: Igor Mammedov <address@hidden>
> > Cc: Michael Tokarev <address@hidden>
> > Cc: Paolo Bonzini <address@hidden>
> > Cc: Richard W.M. Jones <address@hidden>
> > Cc: Shannon Zhao <address@hidden>
> > Cc: Steven Newbury <address@hidden>
> > Cc: Xiao Guangrong <address@hidden>
> > 
> > Thanks
> > Laszlo
> > 
> > Laszlo Ersek (4):
> >   acpi: take oem_id in build_header(), optionally
> >   acpi: expose oem_id and oem_table_id in build_rsdt()
> >   acpi: add function to extract oem_id and oem_table_id from the user's
> >     SLIC
> >   pc: set the OEM fields in the RSDT and the FADT from the SLIC
> > 
> >  include/hw/acpi/acpi.h      |  7 +++++++
> >  include/hw/acpi/aml-build.h |  5 +++--
> >  hw/acpi/aml-build.c         | 14 ++++++++++----
> >  hw/acpi/core.c              | 16 ++++++++++++++++
> >  hw/acpi/nvdimm.c            |  4 ++--
> >  hw/arm/virt-acpi-build.c    | 14 +++++++-------
> >  hw/i386/acpi-build.c        | 31 ++++++++++++++++++-------------
> >  qemu-options.hx             |  4 ++++
> >  8 files changed, 67 insertions(+), 28 deletions(-)
> > 
> > -- 
> > 1.8.3.1
> > 
> >
> 
> -- 
> Sent from my Joll

-- 
Sent from my Jolla