Re: [Qemu-devel] [PATCH v4 0/4] Convert chardevs to QIOChannel & add TLS support

[Paolo Bonzini]

On 19/01/2016 12:14, Daniel P. Berrange wrote:
> This is an update of patches previously shown in an RFC posting
> 
>   RFC: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00829.html
>    v1: https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg04222.html
>    v2: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03823.html
>    v3: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg01601.html
> 
> This short series converts the chardev backends to use the new
> QIOChannel framework. After doing so it then adds support for
> TLS encryption of TCP chardevs. The commit message in the last
> patch explains the TLS encryption in detail.
> 
> The GIOChannel -> QIOChannel conversion has been validated by
> running the qtest framework, which indeed found a few bugs
> initially which I have since fixed.
> 
> The TLS support has been tested for interoperability using
> the gnutls-serv and gnutls-client programs which provide
> stub TLS endpoints/clients respectively.
> 
> Changed in v4:
> 
>  - Rebase to resolve conflicts with recent merged patches

Thanks, this looks good!

Paolo

> Changed in v3:
> 
>  - Fix buffer update after partial send of telnet data
> 
> Daniel P. Berrange (4):
>   char: remove fixed length filename allocation
>   char: convert from GIOChannel to QIOChannel
>   char: don't assume telnet initialization will not block
>   char: introduce support for TLS encrypted TCP chardev backend
> 
>  qapi-schema.json |   2 +
>  qemu-char.c      | 913 
> ++++++++++++++++++++++++++++---------------------------
>  qemu-options.hx  |   9 +-
>  tests/Makefile   |   2 +-
>  4 files changed, 479 insertions(+), 447 deletions(-)
>