[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 04/10] pcie: Introduce function for DSN c
From: |
Shmulik Ladkani |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 04/10] pcie: Introduce function for DSN capability creation |
Date: |
Tue, 19 Jan 2016 17:02:45 +0200 |
Hi Marcel,
On Tue, 19 Jan 2016 16:26:31 +0200, address@hidden wrote:
> >
> > +/* DSN */
> > +#define PCI_DSN_VER 1
> > +#define PCI_DSN_SIZEOF 8
>
> Are you sure the size of DSN is 8?
> Looking at PCIe spec 3, chapter 7.12 I see 12, but I might be wrong.
Total size (DSN ext. cap header + Serial Number register) is indeed 12.
The Serial Number register itself is 64 bits.
Newer qemu already has PCI_EXT_CAP_DSN_SIZEOF defined as 12
(in standard-headers/linux/pci_regs.h)
We may choose better naming to reflect the '8 size' refers to the
payload.
- [Qemu-devel] [RFC PATCH v2 00/10] Introduce Intel 82574 GbE Controller Emulation (e1000e), Leonid Bloch, 2016/01/18
- [Qemu-devel] [RFC PATCH v2 03/10] pcie: Add support for PCIe CAP v1, Leonid Bloch, 2016/01/18
- [Qemu-devel] [RFC PATCH v2 01/10] msix: make msix_clr_pending() visible for clients, Leonid Bloch, 2016/01/18
- [Qemu-devel] [RFC PATCH v2 02/10] pci: Introduce function for PCI PM capability creation, Leonid Bloch, 2016/01/18
- [Qemu-devel] [RFC PATCH v2 04/10] pcie: Introduce function for DSN capability creation, Leonid Bloch, 2016/01/18
- [Qemu-devel] [RFC PATCH v2 05/10] net: Introduce Toeplitz hash calculator, Leonid Bloch, 2016/01/18
- [Qemu-devel] [RFC PATCH v2 06/10] net: Add macros for ETH address tracing, Leonid Bloch, 2016/01/18
- [Qemu-devel] [RFC PATCH v2 09/10] e1000_regs: Add definitions for Intel 82574-specific bits, Leonid Bloch, 2016/01/18
- [Qemu-devel] [RFC PATCH v2 07/10] net_pkt: Name vmxnet3 packet abstractions more generic, Leonid Bloch, 2016/01/18
- [Qemu-devel] [RFC PATCH v2 08/10] net_pkt: Extend packet abstraction as requied by e1000e functionality, Leonid Bloch, 2016/01/18
- [Qemu-devel] [RFC PATCH v2 10/10] net: Introduce e1000e device emulation, Leonid Bloch, 2016/01/18
- Re: [Qemu-devel] [RFC PATCH v2 00/10] Introduce Intel 82574 GbE Controller Emulation (e1000e), Jason Wang, 2016/01/18