[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 0/5] scripts/dump-guest-memory.py: Add multi-arch
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [RFC 0/5] scripts/dump-guest-memory.py: Add multi-arch support |
Date: |
Wed, 20 Jan 2016 14:50:11 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> On 20/01/2016 11:03, Janosch Frank wrote:
>>
>> In python 3:
>> 1/2 == 0.5
>> 1//2 == 0
>> but a // b == floor(a/b), i.e. a cast is made.
>>
>> Anyway, I got rid of the import with:
>> -(-len_desc // 4)
>
> I would change that to either:
>
> def ceil_div(a, b)
> return -(-a // b)
>
> ...
>
> ceil_div(len_desc, 4)
>
> or
>
> (len_desc + 3) / 4
The latter is *far* easier on my eyes. But you'd still have to truncate
for Python 3.
- Re: [Qemu-devel] [RFC 3/5] scripts/dump-guest-memory.py: Improve python 3 compatibility, (continued)