[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 02/13] typedefs: Add BdrvDirtyBitmap
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v2 02/13] typedefs: Add BdrvDirtyBitmap |
Date: |
Thu, 21 Jan 2016 11:05:24 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, 01/20 09:56, Eric Blake wrote:
> On 01/19/2016 11:11 PM, Fam Zheng wrote:
> > Following patches to refactor and move block dirty bitmap code could use
> > this.
> >
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> > include/block/block.h | 3 +--
> > include/qemu/typedefs.h | 1 +
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/block/block.h b/include/block/block.h
> > index c96923d..483bfd3 100644
> > --- a/include/block/block.h
> > +++ b/include/block/block.h
> > @@ -8,6 +8,7 @@
> > #include "block/accounting.h"
> > #include "qapi/qmp/qobject.h"
> > #include "qapi-types.h"
> > +#include "qemu/hbitmap.h"
> >
> > /* block.c */
> > typedef struct BlockDriver BlockDriver;
> > @@ -472,8 +473,6 @@ void *qemu_try_blockalign(BlockDriverState *bs, size_t
> > size);
> > void *qemu_try_blockalign0(BlockDriverState *bs, size_t size);
> > bool bdrv_qiov_is_aligned(BlockDriverState *bs, QEMUIOVector *qiov);
> >
> > -struct HBitmapIter;
>
> You didn't mention removing this forward declaration in the commit
> message, making it look like an accident.
>
It was intended, so it's the commit message. But I'll split the "#include" and
"HBitmapIter" hunks into another patch.
Fam
- [Qemu-devel] [PATCH v2 00/13] Dirty bitmap changes for migration/persistence work, Fam Zheng, 2016/01/20
- [Qemu-devel] [PATCH v2 01/13] backup: Use Bitmap to replace "s->bitmap", Fam Zheng, 2016/01/20
- [Qemu-devel] [PATCH v2 02/13] typedefs: Add BdrvDirtyBitmap, Fam Zheng, 2016/01/20
- [Qemu-devel] [PATCH v2 04/13] block: Remove unused typedef of BlockDriverDirtyHandler, Fam Zheng, 2016/01/20
- [Qemu-devel] [PATCH v2 03/13] block: Move block dirty bitmap code to separate files, Fam Zheng, 2016/01/20
- [Qemu-devel] [PATCH v2 05/13] block: Hide HBitmap in block dirty bitmap interface, Fam Zheng, 2016/01/20
- [Qemu-devel] [PATCH v2 06/13] HBitmap: Introduce "meta" bitmap to track bit changes, Fam Zheng, 2016/01/20
- [Qemu-devel] [PATCH v2 07/13] tests: Add test code for meta bitmap, Fam Zheng, 2016/01/20
- [Qemu-devel] [PATCH v2 08/13] block: Support meta dirty bitmap, Fam Zheng, 2016/01/20