qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] gtk: use qemu_chr_alloc() to allocate CharDrive


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] gtk: use qemu_chr_alloc() to allocate CharDriverState
Date: Thu, 21 Jan 2016 09:42:26 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0

On 01/21/2016 04:56 AM, Daniel P. Berrange wrote:
> The gd_vc_handler() callback is using g_malloc0() to
> allocate the CharDriverState struct. As a result the
> logfd field is getting initialized to 0, instead of
> -1 when no logfile is requested.
> 
> The result is that when running
> 
>  $ qemu-system-i386 -nodefaults -chardev vc,id=mon0 -mon chardev=mon0
> 
> qemu duplicates all monitor output to stdout as well
> as the GTK window.
> 
> Not using qemu_chr_alloc() was already a bug, but harmless
> until this commit
> 
>   commit d0d7708ba29cbcc343364a46bff981e0ff88366f
>   Author: Daniel P. Berrange <address@hidden>
>   Date:   Mon Jan 11 12:44:41 2016 +0000
> 
>     qemu-char: add logfile facility to all chardev backends
> 
> which exposed the problem as a behaviour regression
> 
> Reported-by: Hervé Poussineau <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  ui/gtk.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]