Re: [Qemu-devel] [PATCH] gtk: use qemu_chr_alloc() to allocate CharDriverState

[Hervé Poussineau]

Le 21/01/2016 12:56, Daniel P. Berrange a écrit :
> The gd_vc_handler() callback is using g_malloc0() to
> allocate the CharDriverState struct. As a result the
> logfd field is getting initialized to 0, instead of
> -1 when no logfile is requested.
>
> The result is that when running
>
>   $ qemu-system-i386 -nodefaults -chardev vc,id=mon0 -mon chardev=mon0
>
> qemu duplicates all monitor output to stdout as well
> as the GTK window.
>
> Not using qemu_chr_alloc() was already a bug, but harmless
> until this commit
>
>    commit d0d7708ba29cbcc343364a46bff981e0ff88366f
>    Author: Daniel P. Berrange <address@hidden>
>    Date:   Mon Jan 11 12:44:41 2016 +0000
>
>      qemu-char: add logfile facility to all chardev backends
>
> which exposed the problem as a behaviour regression
>
> Reported-by: Hervé Poussineau <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>

Tested-by: Hervé Poussineau <address@hidden>

Hervé