[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 10/11] Add Error **errp for xen_pt_config_init()
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 10/11] Add Error **errp for xen_pt_config_init() |
Date: |
Fri, 22 Jan 2016 12:21:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 21/01/2016 18:01, Stefano Stabellini wrote:
> - XEN_PT_LOG(&s->dev, "Failed to initialize %d/%ld reg
> 0x%x in grp_type=0x%x (%d/%ld), rc=%d\n",
> - j,
> ARRAY_SIZE(xen_pt_emu_reg_grps[i].emu_regs),
> - regs->offset,
> xen_pt_emu_reg_grps[i].grp_type,
> - i, ARRAY_SIZE(xen_pt_emu_reg_grps), rc);
> + xen_pt_config_reg_init(s, reg_grp_entry, regs, &err);
> + if (err) {
> + error_append_hint(&err, "Failed to initialize %d/%zu"
> + " reg 0x%x in grp_type = 0x%x (%d/%zu)",
> + j,
> ARRAY_SIZE(xen_pt_emu_reg_grps[i].emu_regs),
Coverity noticed a preexisting problem here. emu_regs is a pointer,
thus ARRAY_SIZE doesn't return what you expect.
Paolo
> + regs->offset,
> xen_pt_emu_reg_grps[i].grp_type,
> + i, ARRAY_SIZE(xen_pt_emu_reg_grps));
> + error_propagate(errp, err);
- [Qemu-devel] [PULL 0/11] xen-20160121, Stefano Stabellini, 2016/01/21
- [Qemu-devel] [PULL 03/11] xen-hvm: Clean up xen_hvm_init() error handling, Stefano Stabellini, 2016/01/21
- [Qemu-devel] [PULL 05/11] xen-pvdevice: convert to realize(), Stefano Stabellini, 2016/01/21
- [Qemu-devel] [PULL 01/11] MAINTAINERS: update Xen files, Stefano Stabellini, 2016/01/21
- [Qemu-devel] [PULL 06/11] Change xen_host_pci_sysfs_path() to return void, Stefano Stabellini, 2016/01/21
- [Qemu-devel] [PULL 08/11] Add Error **errp for xen_host_pci_device_get(), Stefano Stabellini, 2016/01/21
- [Qemu-devel] [PULL 09/11] Add Error **errp for xen_pt_setup_vga(), Stefano Stabellini, 2016/01/21
- [Qemu-devel] [PULL 02/11] xenfb.c: avoid expensive loops when prod <= out_cons, Stefano Stabellini, 2016/01/21
- [Qemu-devel] [PULL 11/11] Xen PCI passthru: convert to realize(), Stefano Stabellini, 2016/01/21