Re: [Qemu-devel] [PATCH 0/6] scripts/dump-guest-memory.py: Add multi-arch support

[Paolo Bonzini]

On 22/01/2016 13:08, Janosch Frank wrote:
> The dump guest memory script for extracting a Linux core from a qemu
> core is currently limited to amd64 and python 2.
> 
> With this series we add support for python 3 (while maintaining python
> 2 support) and add the possibility to extract dumps from VMs with the
> most common architectures.
> 
> Tested on X86_64, s390 and Aarch64-le (thanks to Andrew Jones).
> 
> RFC to PATCH:
>     Tested on X86_64 and Aarch64-le.
>     Fix wrongly indented return in get_guest_phys_blocks().
>     Fix wrong indent for predecessor_size that happened when copying.
>     Fix inconsistent line wrapping.
>     Fix python 3 compatibility comment being added in the wrong commit.
>     Fix docstrings that get displayed by gdb.
>     Replaced ceil(len_desc / 4.0) with ((len_desc + 3) // 4)
>     Added patch that fixes module docstring to account for moved gdb
>     help string.
> 
> Janosch Frank (6):
>   scripts/dump-guest-memory.py: Move constants to the top
>   scripts/dump-guest-memory.py: Make methods functions
>   scripts/dump-guest-memory.py: Improve python 3 compatibility
>   scripts/dump-guest-memory.py: Cleanup functions
>   scripts/dump-guest-memory.py: Introduce multi-arch support
>   scripts/dump-guest-memory.py: Fix module docstring
> 
>  scripts/dump-guest-memory.py | 754 
> +++++++++++++++++++++++++++----------------
>  1 file changed, 472 insertions(+), 282 deletions(-)
> 

Queued, thanks.

Paolo