qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v9 25/37] spapr_drc: Expose 'null' in qom-get wh


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v9 25/37] spapr_drc: Expose 'null' in qom-get when there is no fdt
Date: Fri, 22 Jan 2016 20:15:01 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Eric Blake <address@hidden> writes:

> Now that the QMP output visitor supports an explicit null
> output, we should utilize it to make it easier to diagnose
> the difference between a missing fdt vs. a present-but-empty
> one.

Please spell out that we change the value from {} to null.

>
> (Note that this reverts the behavior of commit ab8bf1d, taking
> us back to the behavior of commit 6c2f9a1 [which in turn
> stemmed from a crash fix in 1d10b44]; but that this time,
> the change is intentional and not an accidental side-effect.)
>
> Signed-off-by: Eric Blake <address@hidden>
> Acked-by: David Gibson <address@hidden>
>
> ---
> v9: improved commit message
> v8: rebase to 'name' motion
> v7: new patch, based on discussion about spapr_drc.c
> ---
>  hw/ppc/spapr_drc.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
> index ffc2cd9..831ce23 100644
> --- a/hw/ppc/spapr_drc.c
> +++ b/hw/ppc/spapr_drc.c
> @@ -259,11 +259,7 @@ static void prop_get_fdt(Object *obj, Visitor *v, const 
> char *name,
>      void *fdt;
>
>      if (!drc->fdt) {
> -        visit_start_struct(v, name, NULL, 0, &err);
> -        if (!err) {
> -            visit_end_struct(v, &err);
> -        }
> -        error_propagate(errp, err);
> +        visit_type_null(v, NULL, errp);
>          return;
>      }

Easier to read, always welcome :)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]