qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/3] merge SSDT into DSDT


From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH 0/3] merge SSDT into DSDT
Date: Sun, 24 Jan 2016 08:32:23 +0200

On Fri, Jan 22, 2016 at 03:36:05PM +0100, Igor Mammedov wrote:
> Merging both tables will allow for futher ASL
> simplification and cleanups per device/subsystem
> And it also allows to reduce number of expected
> binary blobs for ACPI tests which reduces tests
> maintenance.

What this does break, however, is adding XSDT which
we might need to do in the future.
I'd rather do the reverse and have as much as possible
in the SSDT.

> Boot tested with RHEL72, WS2003, WS2012R2 guests.
> 
> git tree for testing:
> https://github.com/imammedo/qemu.git merge_ssdt_into_dsdt_v1 
> 
> Igor Mammedov (3):
>   pc: acpi: merge SSDT into DSDT
>   tests: pc: acpi: drop not needed 'expected SSDT' blobs
>   tests: pc: acpi: add expected DSDT.bridge blobs and update DSDT blobs
> 
>  hw/i386/acpi-build.c                 | 246 
> ++++++++++++++++-------------------
>  tests/acpi-test-data/pc/DSDT         | Bin 3028 -> 5478 bytes
>  tests/acpi-test-data/pc/DSDT.bridge  | Bin 0 -> 7337 bytes
>  tests/acpi-test-data/pc/SSDT         | Bin 2486 -> 0 bytes
>  tests/acpi-test-data/pc/SSDT.bridge  | Bin 4345 -> 0 bytes
>  tests/acpi-test-data/q35/DSDT        | Bin 7666 -> 8321 bytes
>  tests/acpi-test-data/q35/DSDT.bridge | Bin 0 -> 8338 bytes
>  tests/acpi-test-data/q35/SSDT        | Bin 691 -> 0 bytes
>  tests/acpi-test-data/q35/SSDT.bridge | Bin 708 -> 0 bytes
>  9 files changed, 111 insertions(+), 135 deletions(-)
>  create mode 100644 tests/acpi-test-data/pc/DSDT.bridge
>  delete mode 100644 tests/acpi-test-data/pc/SSDT
>  delete mode 100644 tests/acpi-test-data/pc/SSDT.bridge
>  create mode 100644 tests/acpi-test-data/q35/DSDT.bridge
>  delete mode 100644 tests/acpi-test-data/q35/SSDT
>  delete mode 100644 tests/acpi-test-data/q35/SSDT.bridge
> 
> -- 
> 1.8.3.1



reply via email to

[Prev in Thread] Current Thread [Next in Thread]