[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 24/28] target-ppc: gdbstub: fix spe registers for lit
From: |
David Gibson |
Subject: |
[Qemu-devel] [PULL 24/28] target-ppc: gdbstub: fix spe registers for little-endian guests |
Date: |
Mon, 25 Jan 2016 12:15:23 +1100 |
From: Greg Kurz <address@hidden>
Let's reuse the ppc_maybe_bswap_register() helper, like we already do
with the general registers.
Signed-off-by: Greg Kurz <address@hidden>
Signed-off-by: David Gibson <address@hidden>
---
target-ppc/translate_init.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 4c29912..6625bb5 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -8849,6 +8849,7 @@ static int gdb_get_spe_reg(CPUPPCState *env, uint8_t
*mem_buf, int n)
if (n < 32) {
#if defined(TARGET_PPC64)
stl_p(mem_buf, env->gpr[n] >> 32);
+ ppc_maybe_bswap_register(env, mem_buf, 4);
#else
stl_p(mem_buf, env->gprh[n]);
#endif
@@ -8856,10 +8857,12 @@ static int gdb_get_spe_reg(CPUPPCState *env, uint8_t
*mem_buf, int n)
}
if (n == 32) {
stq_p(mem_buf, env->spe_acc);
+ ppc_maybe_bswap_register(env, mem_buf, 8);
return 8;
}
if (n == 33) {
stl_p(mem_buf, env->spe_fscr);
+ ppc_maybe_bswap_register(env, mem_buf, 4);
return 4;
}
return 0;
@@ -8870,7 +8873,11 @@ static int gdb_set_spe_reg(CPUPPCState *env, uint8_t
*mem_buf, int n)
if (n < 32) {
#if defined(TARGET_PPC64)
target_ulong lo = (uint32_t)env->gpr[n];
- target_ulong hi = (target_ulong)ldl_p(mem_buf) << 32;
+ target_ulong hi;
+
+ ppc_maybe_bswap_register(env, mem_buf, 4);
+
+ hi = (target_ulong)ldl_p(mem_buf) << 32;
env->gpr[n] = lo | hi;
#else
env->gprh[n] = ldl_p(mem_buf);
@@ -8878,10 +8885,12 @@ static int gdb_set_spe_reg(CPUPPCState *env, uint8_t
*mem_buf, int n)
return 4;
}
if (n == 32) {
+ ppc_maybe_bswap_register(env, mem_buf, 8);
env->spe_acc = ldq_p(mem_buf);
return 8;
}
if (n == 33) {
+ ppc_maybe_bswap_register(env, mem_buf, 4);
env->spe_fscr = ldl_p(mem_buf);
return 4;
}
--
2.5.0
- Re: [Qemu-devel] [PULL 01/28] target-ppc: Use sensible POWER8/POWER8E versions, (continued)
[Qemu-devel] [PULL 15/28] pseries: Clean up error handling in spapr_rtas_register(), David Gibson, 2016/01/24
[Qemu-devel] [PULL 14/28] pseries: Clean up error handling in spapr_vga_init(), David Gibson, 2016/01/24
[Qemu-devel] [PULL 21/28] target-ppc: gdbstub: fix float registers for little-endian guests, David Gibson, 2016/01/24
[Qemu-devel] [PULL 16/28] pseries: Clean up error handling in xics_system_init(), David Gibson, 2016/01/24
[Qemu-devel] [PULL 27/28] cuda.c: return error for unknown commands, David Gibson, 2016/01/24
[Qemu-devel] [PULL 28/28] uninorth.c: add support for UniNorth kMacRISCPCIAddressSelect (0x48) register, David Gibson, 2016/01/24
[Qemu-devel] [PULL 25/28] target-ppc: gdbstub: Add VSX support, David Gibson, 2016/01/24
[Qemu-devel] [PULL 17/28] pseries: Clean up error reporting in ppc_spapr_init(), David Gibson, 2016/01/24
[Qemu-devel] [PULL 24/28] target-ppc: gdbstub: fix spe registers for little-endian guests,
David Gibson <=
[Qemu-devel] [PULL 22/28] target-ppc: gdbstub: introduce avr_need_swap(), David Gibson, 2016/01/24
[Qemu-devel] [PULL 23/28] target-ppc: gdbstub: fix altivec registers for little-endian guests, David Gibson, 2016/01/24
Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125, Peter Maydell, 2016/01/25
- Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125, David Gibson, 2016/01/25
- Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125, Peter Maydell, 2016/01/25
- Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125, David Gibson, 2016/01/25
- Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125, Peter Maydell, 2016/01/25
- Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125, David Gibson, 2016/01/26
- Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125, Alexander Graf, 2016/01/26
- Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125, Gerd Hoffmann, 2016/01/26