[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 6/8] hw/arm/sysbus-fdt: helpers for clock nod
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 6/8] hw/arm/sysbus-fdt: helpers for clock node generation |
|
Date: |
Mon, 25 Jan 2016 14:34:34 +0000 |
On 25 January 2016 at 14:09, Eric Auger <address@hidden> wrote:
> Hi Peter,
> On 01/25/2016 03:05 PM, Peter Maydell wrote:
>> On 18 January 2016 at 15:16, Eric Auger <address@hidden> wrote:
>> Don't we want to return here, rather than continuing with the
>> rest of the function? ("goto err;" with an err: label before
>> the g_free() at the bottom of the function probably best since
>> some of the error paths need to free that.)
> due to the &error_fatal, we are going to exit here. I thought it is not
> worth going further if we can't find the clock node.
Yes, sorry, I didn't notice the error_fatal til I got to about
the last patch I reviewed. You can ignore similar comments
I made about some of the other patches.
thanks
-- PMM
- Re: [Qemu-devel] [PATCH v5 2/8] device_tree: introduce load_device_tree_from_sysfs, (continued)
- [Qemu-devel] [PATCH v5 1/8] hw/vfio/platform: amd-xgbe device, Eric Auger, 2016/01/18
- [Qemu-devel] [PATCH v5 3/8] device_tree: introduce qemu_fdt_node_path, Eric Auger, 2016/01/18
- [Qemu-devel] [PATCH v5 5/8] device_tree: qemu_fdt_getprop_cell converted to use the error API, Eric Auger, 2016/01/18
- [Qemu-devel] [PATCH v5 4/8] device_tree: qemu_fdt_getprop converted to use the error API, Eric Auger, 2016/01/18
- [Qemu-devel] [PATCH v5 6/8] hw/arm/sysbus-fdt: helpers for clock node generation, Eric Auger, 2016/01/18
[Qemu-devel] [PATCH v5 7/8] hw/arm/sysbus-fdt: enable amd-xgbe dynamic instantiation, Eric Auger, 2016/01/18
[Qemu-devel] [PATCH v5 8/8] hw/arm/sysbus-fdt: remove qemu_fdt_setprop returned value check, Eric Auger, 2016/01/18