[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 1/7] net/filter: Fix the output information
From: |
Jason Wang |
Subject: |
Re: [Qemu-devel] [PATCH RFC 1/7] net/filter: Fix the output information for command 'info network' |
Date: |
Tue, 26 Jan 2016 11:05:39 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
On 01/25/2016 01:58 PM, Hailiang Zhang wrote:
> On 2016/1/25 13:01, Jason Wang wrote:
>>
>>
>> On 01/22/2016 04:36 PM, zhanghailiang wrote:
>>> The properties of netfilter object could be changed by 'qom-set'
>>> command, but the output of 'info network' command is not updated,
>>> because it got the old information through nf->info_str, it will
>>> not be updated while we change the value of netfilter's property.
>>>
>>> Here we split a the helper function that could colletct the output
>>> information for filter, and also remove the useless member
>>> 'info_str' from struct NetFilterState.
>>>
>>> Signed-off-by: zhanghailiang <address@hidden>
>>> ---
>>
>> Looks like a bug fix. Please send as a independent formal patch and
>> better cc Markus and Eric for better reviewing.
>>
>
> OK, by the way, i didn't see there was a corresponding qmp command
> for 'info network', is the hmp_info_network just an experimental
> command ?
It's for debugging I think , and if you want it to be used by
management, probably need a qmp version.
Thanks
[Qemu-devel] [PATCH RFC 4/7] net/filter: Introduce a helper to add a filter to the netdev, zhanghailiang, 2016/01/22
[Qemu-devel] [PATCH RFC 3/7] net/filter: Skip the disabled filter when delivering packets, zhanghailiang, 2016/01/22
[Qemu-devel] [PATCH RFC 5/7] filter-buffer: Accept zero interval, zhanghailiang, 2016/01/22