[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] net/filter: Fix the output information for c
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] net/filter: Fix the output information for command 'info network' |
|
Date: |
Tue, 26 Jan 2016 09:59:38 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 01/25/2016 11:43 PM, zhanghailiang wrote:
> The properties of netfilter object could be changed by 'qom-set'
> command, but the output of 'info network' command is not updated,
> because it got the old information through nf->info_str, it will
> not be updated while we change the value of netfilter's property.
>
> Here we split a helper function that could collect the output
> information for filter, and also remove the useless member
> 'info_str' from struct NetFilterState.
>
> Signed-off-by: zhanghailiang <address@hidden>
> Cc: Jason Wang <address@hidden>
> Cc: Eric Blake <address@hidden>
> Cc: Markus Armbruster <address@hidden>
> Cc: Yang Hongyang <address@hidden>
> ---
> v2:
> - write the information to monitor directly instead of
> printing into a temporary string before output them. (Eric's comment)
Looks a lot nicer compared to v1!
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature