[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/5] pc: Remove unused pc_acpi_init() function
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH 6/5] pc: Remove unused pc_acpi_init() function |
Date: |
Tue, 26 Jan 2016 18:27:09 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
On 01/26/16 15:59, Eduardo Habkost wrote:
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> Additional code we can remove after removing the old q35
> machines.
> ---
> hw/i386/pc.c | 28 ----------------------------
> include/hw/i386/pc.h | 1 -
> 2 files changed, 29 deletions(-)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 78cf8fa..f68c0c6 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1233,34 +1233,6 @@ void pc_pci_as_mapping_init(Object *owner,
> MemoryRegion *system_memory,
> pci_address_space, -1);
> }
>
> -void pc_acpi_init(const char *default_dsdt)
> -{
> - char *filename;
> -
> - if (acpi_tables != NULL) {
> - /* manually set via -acpitable, leave it alone */
> - return;
> - }
> -
> - filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, default_dsdt);
> - if (filename == NULL) {
> - fprintf(stderr, "WARNING: failed to find %s\n", default_dsdt);
> - } else {
> - QemuOpts *opts = qemu_opts_create(qemu_find_opts("acpi"), NULL, 0,
> - &error_abort);
> - Error *err = NULL;
> -
> - qemu_opt_set(opts, "file", filename, &error_abort);
> -
> - acpi_table_add_builtin(opts, &err);
> - if (err) {
> - error_reportf_err(err, "WARNING: failed to load %s: ",
> - filename);
> - }
> - g_free(filename);
> - }
> -}
> -
> FWCfgState *xen_load_linux(PCMachineState *pcms,
> PcGuestInfo *guest_info)
> {
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 65e8f24..3bc9e62 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -230,7 +230,6 @@ void pc_acpi_smi_interrupt(void *opaque, int irq, int
> level);
>
> void pc_cpus_init(PCMachineState *pcms);
> void pc_hot_add_cpu(const int64_t id, Error **errp);
> -void pc_acpi_init(const char *default_dsdt);
>
> PcGuestInfo *pc_guest_info_init(PCMachineState *pcms);
>
>
Reviewed-by: Laszlo Ersek <address@hidden>
- [Qemu-devel] [PATCH v2 1/5] q35: Remove old machine versions, (continued)
- [Qemu-devel] [PATCH v2 1/5] q35: Remove old machine versions, Eduardo Habkost, 2016/01/23
- [Qemu-devel] [PATCH v2 2/5] machine: Remove no_tco field, Eduardo Habkost, 2016/01/23
- [Qemu-devel] [PATCH v2 3/5] ich9: Remove enable_tco arguments from init functions, Eduardo Habkost, 2016/01/23
- [Qemu-devel] [PATCH v2 4/5] q35: Remove unused q35-acpi-dsdt.aml file, Eduardo Habkost, 2016/01/23
- [Qemu-devel] [PATCH v2 5/5] q35: No need to check gigabyte_align, Eduardo Habkost, 2016/01/23
- Re: [Qemu-devel] [PATCH v2 0/5] q35: Remove old machines and unused compat code, Laszlo Ersek, 2016/01/25
- Re: [Qemu-devel] [PATCH v2 0/5] q35: Remove old machines and unused compat code, Igor Mammedov, 2016/01/26
- [Qemu-devel] [PATCH 6/5] pc: Remove unused pc_acpi_init() function, Eduardo Habkost, 2016/01/26
- Re: [Qemu-devel] [PATCH 6/5] pc: Remove unused pc_acpi_init() function,
Laszlo Ersek <=
- [Qemu-devel] [PATCH 7/5] acpi: Remove unused acpi_table_add_builtin() function, Eduardo Habkost, 2016/01/26