qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 0/3] qapi-visit: Unify struct and union visit


From: Markus Armbruster
Subject: [Qemu-devel] [PATCH 0/3] qapi-visit: Unify struct and union visit
Date: Wed, 27 Jan 2016 14:54:45 +0100

I got stuck reviewing "[PATCH v9 31/37] qapi-visit: Unify struct and
union visit".  The result is probably fine, but the patch itself is
impenetrable for me.  Here's my version.  I believe it's really simple
to review (but as the author, I'm hopelessly biased).

I based on PATCH 26/37 instead of PATCH 30, because I found the empty
struct stuff from PACTH 27-30 not useful for this unification job.  If
we want it for other reasons (I have no opinion, yet), rebasing it
onto this series shouldn't be hard.

Markus Armbruster (3):
  qapi-visit: Simplify how we visit common union members
  qapi-visit: Clean up code generated around visit_end_union()
  qapi-visit: Unify struct and union visit

 scripts/qapi-visit.py | 122 +++++++++++++++-----------------------------------
 1 file changed, 36 insertions(+), 86 deletions(-)

-- 
2.4.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]