Re: [Qemu-devel] [PATCH v1 2/5] configure: ensure ldflags propagated to config_host

[Paolo Bonzini]

On 28/01/2016 11:15, Alex Bennée wrote:
> index d0de2d4..d30532f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -329,9 +329,9 @@ qemu-ga: qemu-ga$(EXESUF) $(QGA_VSS_PROVIDER) 
> $(QEMU_GA_MSI)
>  endif
>  
>  ivshmem-client$(EXESUF): $(ivshmem-client-obj-y)
> -     $(call LINK, $^)
> +     $(call LINK, $^, $(ldflags))
>  ivshmem-server$(EXESUF): $(ivshmem-server-obj-y) libqemuutil.a libqemustub.a
> -     $(call LINK, $^)
> +     $(call LINK, $^, $(ldflags))
>  
>  clean:
>  # avoid old build problems by removing potentially incorrect old files

This seems spurious?  There's no $2 in the LINK macro.

> diff --git a/configure b/configure
> index bd29ba7..148b79a 100755
> --- a/configure
> +++ b/configure
> @@ -5871,7 +5871,7 @@ if test "$target_linux_user" = "yes" -o 
> "$target_bsd_user" = "yes" ; then
>    ldflags="$ldflags $textseg_ldflags"
>  fi
>  
> -echo "LDFLAGS+=$ldflags" >> $config_target_mak
> +echo "LDFLAGS+=$ldflags" >> $config_host_mak
>  echo "QEMU_CFLAGS+=$cflags" >> $config_target_mak
>  
>  done # for target in $targets
> -- 2.7.0

This is good.

Paolo