qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] virtio-pci: call pci reset variant when gues


From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH v2] virtio-pci: call pci reset variant when guest clears status.
Date: Thu, 28 Jan 2016 13:26:03 +0200

On Thu, Jan 28, 2016 at 10:33:25AM +0100, Gerd Hoffmann wrote:
> > >          if (vdev->status == 0) {
> > > -            virtio_reset(vdev);
> > > -            msix_unuse_all_vectors(&proxy->pci_dev);
> > > +            virtio_pci_reset(DEVICE(proxy));
> > >          }
> > >  
> > >          /* Linux before 2.6.34 drives the device without enabling
> > 
> > Aren't there two call sites in virtio_ioport_write?
> 
> /me was specifically fixing clear-status code paths mentioned in the
> commit message.
> 
> Yes, there is another one, not fully sure what is supposed to happen
> there.
> 
> cheers,
>   Gerd

Same thing really - virtio 0 has two equivalent ways to
reset a device: write 0 into status or write 0 into PFN
register.

-- 
MST



reply via email to

[Prev in Thread] Current Thread [Next in Thread]