[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v19 7/9] machine: add properties to compat_props
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v19 7/9] machine: add properties to compat_props incrementaly |
Date: |
Thu, 28 Jan 2016 12:02:12 -0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Jan 28, 2016 at 11:58:08AM +0100, Igor Mammedov wrote:
> Switch to adding compat properties incrementaly instead of
> completly overwriting compat_props per machine type.
> That removes data duplication which we have due to nested
> [PC|SPAPR]_COMPAT_* macros.
>
> It also allows to set default device properties from
> default foo_machine_options() hook, which will be used
> in following patch for putting VMGENID device as
> a function if ISA bridge on pc/q35 machines.
>
> Suggested-by: Eduardo Habkost <address@hidden>
> Signed-off-by: Igor Mammedov <address@hidden>
>
Very nice. The only suggestion I have is to use the simpler GList
type, instead of GArray.
Reviewed-by: Eduardo Habkost <address@hidden>
> compat_props GArray
I assume this line was left here by mistake?
> ---
> hw/core/machine.c | 10 ++++++++++
> hw/ppc/spapr.c | 3 ---
> hw/s390x/s390-virtio-ccw.c | 12 ++----------
> include/hw/boards.h | 11 +++++++++--
> include/hw/i386/pc.h | 9 ---------
> vl.c | 6 +++++-
> 6 files changed, 26 insertions(+), 25 deletions(-)
[...]
--
Eduardo
[Qemu-devel] [PATCH v19 4/9] tests: add a unit test for the vmgenid device., Igor Mammedov, 2016/01/28
[Qemu-devel] [PATCH v19 5/9] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands, Igor Mammedov, 2016/01/28
[Qemu-devel] [PATCH v19 6/9] qmp/hmp: add set-vm-generation-id commands, Igor Mammedov, 2016/01/28
[Qemu-devel] [PATCH v19 9/9] pc/q53: by default put vmgenid device as an function of ISA bridge, Igor Mammedov, 2016/01/28
[Qemu-devel] [PATCH v19 8/9] pc: put PIIX3 in slot 1 explicitly and cleanup functions assignment, Igor Mammedov, 2016/01/28
[Qemu-devel] [PATCH v19 7/9] machine: add properties to compat_props incrementaly, Igor Mammedov, 2016/01/28