Re: [Qemu-devel] [PATCH v1 06/22] migration: force QEMUFile to blocking mode for outgoing migration

[Dr. David Alan Gilbert]

* Daniel P. Berrange (address@hidden) wrote:
> Instead of relying on the default QEMUFile I/O blocking flag
> state, explicitly turn on blocking I/O for outgoing migration
> since it takes place in a background thread.
> 
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  migration/migration.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/migration/migration.c b/migration/migration.c
> index c964a8d..715f069 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1732,6 +1732,7 @@ void migrate_fd_connect(MigrationState *s)
>      s->expected_downtime = max_downtime/1000000;
>      s->cleanup_bh = qemu_bh_new(migrate_fd_cleanup, s);
>  
> +    qemu_file_set_blocking(s->file, true);

Yes OK; fd_connect is the outgoing side and qemu_fopen_socket
already sets blocking on "w".

Reviewed-by: Dr. David Alan Gilbert <address@hidden>

>      qemu_file_set_rate_limit(s->file,
>                               s->bandwidth_limit / XFER_LIMIT_RATIO);
>  
> -- 
> 2.5.0
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK