Re: [Qemu-devel] [PATCH 5/6] qmp-commands.hx: Fix the missing options for migration parameters commands

[Dr. David Alan Gilbert]

* zhanghailiang (address@hidden) wrote:
> We didn't document x-cpu-throttle-initial/x-cpu-throttle-increment for
> commands migrate-set-parameters and query-migrate-parameters.
> 
> Here we add the descriptions for these two options and fix the wrong example
> for query-migrate-parameters qmp commands.
> Besides, this will also fix the bug that we can't set x-cpu-throttle-initial
> and x-cpu-throttle-increment through migrate-set-parameters qmp command.
> 
> Signed-off-by: zhanghailiang <address@hidden>

(cc'd in Jason who wrote the autothrottle)

Reviewed-by: Dr. David Alan Gilbert <address@hidden>

> ---
>  qmp-commands.hx | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)
> 
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index db072a6..0a2cded 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -3700,6 +3700,10 @@ Set migration parameters
>  - "compress-level": set compression level during migration (json-int)
>  - "compress-threads": set compression thread count for migration (json-int)
>  - "decompress-threads": set decompression thread count for migration 
> (json-int)
> +- "x-cpu-throttle-initial": set initial percentage of time guest cpus are
> +                           throttled for auto-coverge (json-int)
> +- "x-cpu-throttle-increment": set throttle increasing percentage for
> +                             auto-converge (json-int)
>  
>  Arguments:
>  
> @@ -3713,7 +3717,7 @@ EQMP
>      {
>          .name       = "migrate-set-parameters",
>          .args_type  =
> -            "compress-level:i?,compress-threads:i?,decompress-threads:i?",
> +            
> "compress-level:i?,compress-threads:i?,decompress-threads:i?,x-cpu-throttle-initial:i?,x-cpu-throttle-increment:i?",
>          .mhandler.cmd_new = qmp_marshal_migrate_set_parameters,
>      },
>  SQMP
> @@ -3726,6 +3730,10 @@ Query current migration parameters
>           - "compress-level" : compression level value (json-int)
>           - "compress-threads" : compression thread count value (json-int)
>           - "decompress-threads" : decompression thread count value (json-int)
> +         - "x-cpu-throttle-initial" : initial percentage of time guest cpus 
> are
> +                                      throttled (json-int)
> +         - "x-cpu-throttle-increment" : throttle increasing percentage for
> +                                        auto-converge (json-int)
>  
>  Arguments:
>  
> @@ -3734,9 +3742,11 @@ Example:
>  -> { "execute": "query-migrate-parameters" }
>  <- {
>        "return": {
> -         "decompress-threads", 2,
> -         "compress-threads", 8,
> -         "compress-level", 1
> +         "decompress-threads": 2,
> +         "x-cpu-throttle-increment": 10,
> +         "compress-threads": 8,
> +         "compress-level": 1,
> +         "x-cpu-throttle-initial": 20
>        }
>     }
>  
> -- 
> 1.8.3.1
> 
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK