[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 4/5] util: [ppc] Use new error_report_abort()
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 4/5] util: [ppc] Use new error_report_abort() instead of abort() |
Date: |
Thu, 28 Jan 2016 14:45:58 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 01/28/2016 02:41 PM, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
> target-ppc/kvm.c | 4 ++--
> target-ppc/kvm_ppc.h | 15 +++++++++------
> target-ppc/mmu-hash32.c | 5 +++--
> target-ppc/mmu_helper.c | 3 +--
> 4 files changed, 15 insertions(+), 12 deletions(-)
>
> +++ b/target-ppc/kvm_ppc.h
> @@ -9,6 +9,9 @@
> #ifndef __KVM_PPC_H__
> #define __KVM_PPC_H__
>
> +#include "qemu/error-report.h"
> +
> +
> #define TYPE_HOST_POWERPC_CPU "host-" TYPE_POWERPC_CPU
>
> #ifdef CONFIG_KVM
> @@ -220,36 +223,36 @@ static inline int kvmppc_get_htab_fd(bool write)
> static inline int kvmppc_save_htab(QEMUFile *f, int fd, size_t bufsize,
> int64_t max_ns)
> {
> - abort();
> + error_report_abort(" ");
Aborting with an empty string with trailing spaces feels awkward.
Either this should be a real message, or abort() was just fine.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC][PATCH v4 0/5] utils: Improve and document error reporting, Lluís Vilanova, 2016/01/28
- [Qemu-devel] [PATCH v4 1/5] util: Introduce error reporting functions with fatal/abort, Lluís Vilanova, 2016/01/28
- [Qemu-devel] [PATCH v4 3/5] util: [ppc] Use new error_report_fatal() instead of exit(), Lluís Vilanova, 2016/01/28
- [Qemu-devel] [PATCH v4 4/5] util: [ppc] Use new error_report_abort() instead of abort(), Lluís Vilanova, 2016/01/28
- Re: [Qemu-devel] [PATCH v4 4/5] util: [ppc] Use new error_report_abort() instead of abort(),
Eric Blake <=
- [Qemu-devel] [PATCH v4 2/5] util: Use new error_report_fatal/abort instead of error_setg(&error_fatal/abort), Lluís Vilanova, 2016/01/28
- [Qemu-devel] [PATCH v4 5/5] doc: Introduce coding style for errors, Lluís Vilanova, 2016/01/28
- Re: [Qemu-devel] [RFC][PATCH v4 0/5] utils: Improve and document error reporting, Lluís Vilanova, 2016/01/28