[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 5/5] doc: Introduce coding style for errors
|
From: |
Lluís Vilanova |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 5/5] doc: Introduce coding style for errors |
|
Date: |
Fri, 29 Jan 2016 14:33:52 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake writes:
> On 01/28/2016 02:53 PM, Lluís Vilanova wrote:
>> Gives some general guidelines for reporting errors in QEMU.
>>
>> Signed-off-by: Lluís Vilanova <address@hidden>
>> ---
>> HACKING | 33 +++++++++++++++++++++++++++++++++
>> 1 file changed, 33 insertions(+)
> I'm not sure if my v4 review crossed paths with this, but I still see typos:
>> +
>> +WARNING: The special 'error_fatal' and 'error_abort' objects follow the same
>> +constrains as the 'error_report_fatal' and 'error_report_abort' functions.
> s/constrains/constraints/
We did cross paths, sorry. It's fixed on upcoming v6.
Lluis
- [Qemu-devel] [RFC][PATCH v5 0/5] utils: Improve and document error reporting, Lluís Vilanova, 2016/01/28
- [Qemu-devel] [PATCH v5 1/5] util: Introduce error reporting functions with fatal/abort, Lluís Vilanova, 2016/01/28
- [Qemu-devel] [PATCH v5 2/5] util: Use new error_report_fatal/abort instead of error_setg(&error_fatal/abort), Lluís Vilanova, 2016/01/28
- [Qemu-devel] [PATCH v5 3/5] util: [ppc] Use new error_report_fatal() instead of exit(), Lluís Vilanova, 2016/01/28
- [Qemu-devel] [PATCH v5 4/5] util: [ppc] Use new error_report_abort() instead of abort(), Lluís Vilanova, 2016/01/28
- [Qemu-devel] [PATCH v5 5/5] doc: Introduce coding style for errors, Lluís Vilanova, 2016/01/28