[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] usb: ehci: add capability mmio write function
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH] usb: ehci: add capability mmio write function |
|
Date: |
Fri, 29 Jan 2016 14:45:14 +0100 |
On Fr, 2016-01-29 at 18:30 +0530, P J P wrote:
> From: Prasad J Pandit <address@hidden>
>
> USB Ehci emulation supports host controller capability registers.
> But its mmio '.write' function was missing, which lead to a null
> pointer dereference issue. Add a do nothing 'ehci_caps_write'
> definition to avoid it; Do nothing because capability registers
> are Read Only(RO).
Surely makes sense, xhci does the same, I'll pick it up.
Maybe we should have a generic nop_write function somewhere. Not that
there can much go wrong by cut&pasting here, but still ...
cheers,
Gerd