[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qdev: Use GList for global properties
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH] qdev: Use GList for global properties |
Date: |
Fri, 29 Jan 2016 12:15:12 -0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Jan 28, 2016 at 07:01:12PM +0200, Michael S. Tsirkin wrote:
> On Thu, Jan 28, 2016 at 01:02:26PM -0200, Eduardo Habkost wrote:
> > If the same GlobalProperty struct is registered twice, the list
> > entry gets corrupted, making tqe_next points to itself, and
> > qdev_prop_set_globals() gets stuck in a loop. The bug can be
> > easily reproduced by running:
> >
> > $ qemu-system-x86_64 -rtc-td-hack -rtc-td-hack
> >
> > Change global_props to use GList instead of queue.h, making the
> > code simpler and able to deal with properties being registered
> > twice.
> >
> > Signed-off-by: Eduardo Habkost <address@hidden>
>
> Reviewed-by: Michael S. Tsirkin <address@hidden>
Thanks! It seems we don't have a maintainer for hw/core/qdev*.
Who should merge this?
--
Eduardo