|
From: | Hailiang Zhang |
Subject: | Re: [Qemu-devel] [PATCH RFC v2 2/5] vl: Make object_create() public |
Date: | Mon, 1 Feb 2016 15:34:42 +0800 |
User-agent: | Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
On 2016/2/1 15:27, Jason Wang wrote:
On 02/01/2016 02:19 PM, Hailiang Zhang wrote:On 2016/2/1 11:05, Jason Wang wrote:On 01/27/2016 04:29 PM, zhanghailiang wrote:Make the helper object_create() public and fix its first parameter to accept NULL value.Looks not very nice. Maybe pass a new predicate func for sanity check it better.OK, but here is it better to check if the predicate func is NULL ? Thanks, HailiangNot sure, but if you stick to check against NULL, need a separate patch.
OK, i will drop this unnecessary check and add sanity check in next version, thanks.
[Prev in Thread] | Current Thread | [Next in Thread] |