Re: [Qemu-devel] [PATCH 01/10] virtio: move VirtQueueElement at the beginning of the structs

[Cornelia Huck]

On Sun, 31 Jan 2016 11:28:57 +0100
Paolo Bonzini <address@hidden> wrote:

> The next patch will make virtqueue_pop/vring_pop allocate memory for
> the VirtQueueElement. In some cases (blk, scsi, gpu) the device wants
> to extend VirtQueueElement with device-specific fields and, until now,
> the place of the VirtQueueElement within the containing struct didn't
> matter. When allocating the entire block in virtqueue_pop/vring_pop,
> however, the containing struct must basically be a "subclass" of
> VirtQueueElement, with the VirtQueueElement as the first field. Make
> that the case for blk and scsi; gpu is already doing it.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  hw/scsi/virtio-scsi.c           |  3 +--
>  include/hw/virtio/virtio-blk.h  |  2 +-
>  include/hw/virtio/virtio-scsi.h | 13 ++++++-------
>  3 files changed, 8 insertions(+), 10 deletions(-)

Reviewed-by: Cornelia Huck <address@hidden>