qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/8] libqos: remove some leaks


From: Marc-André Lureau
Subject: Re: [Qemu-devel] [PATCH 4/8] libqos: remove some leaks
Date: Mon, 1 Feb 2016 14:59:54 +0100

Hi

On Fri, Jan 29, 2016 at 4:43 PM, Markus Armbruster <address@hidden> wrote:
> The existing users pass a func that saves dev, and free the saved dev
> later.  Works as long as we call func() at most once.  If multiple
> devices match, all but the last one are leaked.  Can this happen?

It is the responsability of the func() callback to deal with multiple
matches. I don't think this needs to change.

This fix is only about the case of unmatching devices that need to be
free within qpci_device_foreach().

Do you ack that fix?


-- 
Marc-André Lureau



reply via email to

[Prev in Thread] Current Thread [Next in Thread]