Re: [Qemu-devel] [PATCH 2/2] ARM: PL061: Misc cleaning fields for PL061 device state

[Peter Maydell]

On 1 February 2016 at 17:20, Wei Huang <address@hidden> wrote:
> This patch removes float_high field of PL061State, which doesn't seem
> to be used anywhere.
>
> Signed-off-by: Wei Huang <address@hidden>
> ---
>  hw/gpio/pl061.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/hw/gpio/pl061.c b/hw/gpio/pl061.c
> index 342a70d..2c08e88 100644
> --- a/hw/gpio/pl061.c
> +++ b/hw/gpio/pl061.c
> @@ -56,7 +56,6 @@ typedef struct PL061State {
>      uint32_t slr;
>      uint32_t den;
>      uint32_t cr;
> -    uint32_t float_high;
>      uint32_t amsel;
>      qemu_irq irq;
>      qemu_irq out[8];
> @@ -88,7 +87,6 @@ static const VMStateDescription vmstate_pl061 = {
>          VMSTATE_UINT32(slr, PL061State),
>          VMSTATE_UINT32(den, PL061State),
>          VMSTATE_UINT32(cr, PL061State),
> -        VMSTATE_UINT32(float_high, PL061State),
>          VMSTATE_UINT32_V(amsel, PL061State, 2),
>          VMSTATE_END_OF_LIST()

This would be a migration compatibility break, so at a minimum
you need to bump the vmstate struct versions.

thanks
-- PMM