[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 10/25] qapi: Improve generated event use of
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v10 10/25] qapi: Improve generated event use of qapi visitor |
|
Date: |
Mon, 1 Feb 2016 15:50:24 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 02/01/2016 05:31 AM, Markus Armbruster wrote:
>> |+ visit_start_struct(v, NULL, NULL, "ACPI_DEVICE_OST", 0, &err);
>> | if (err) {
>> | goto out;
>> | }
>> | visit_type_ACPIOSTInfo(v, &info, "info", &err);
>> | if (err) {
>> |- goto out;
>> |+ goto out_obj;
>> | }
>> |- visit_end_struct(v, &err);
>> |+out_obj:
>> |+ visit_end_struct(v, err ? NULL : &err);
>
> Slightly awkward example, because out_obj is pointless in this
> degenerated case. You could pick one with multiple members (thus
> multiple goto out_obj), or do pseudo-code hinting at multiple members.
DEVICE_DELETED, DEVICE_TRAY_MOVED, MEM_UNPLUG_ERROR,
NET_RX_FILTER_CHANGED, and SPICE_CONNECTED are nice candidates (two
members instead of one). Do you want to take care of redoing any
portion of the commit message?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature