[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 03/17] net: cadence_gem: check packet size in gem_rec
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PULL 03/17] net: cadence_gem: check packet size in gem_recieve |
Date: |
Tue, 2 Feb 2016 10:36:07 +0800 |
From: Prasad J Pandit <address@hidden>
While receiving packets in 'gem_receive' routine, if Frame Check
Sequence(FCS) is enabled, it copies the packet into a local
buffer without checking its size. Add check to validate packet
length against the buffer size to avoid buffer overflow.
Reported-by: Ling Liu <address@hidden>
Signed-off-by: Prasad J Pandit <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
hw/net/cadence_gem.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
index f9e4091..e513d9d 100644
--- a/hw/net/cadence_gem.c
+++ b/hw/net/cadence_gem.c
@@ -678,6 +678,10 @@ static ssize_t gem_receive(NetClientState *nc, const
uint8_t *buf, size_t size)
} else {
unsigned crc_val;
+ if (size > sizeof(rxbuf) - sizeof(crc_val)) {
+ size = sizeof(rxbuf) - sizeof(crc_val);
+ }
+ bytes_to_copy = size;
/* The application wants the FCS field, which QEMU does not provide.
* We must try and calculate one.
*/
--
2.5.0
- [Qemu-devel] [PULL 00/17] Net patches, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 01/17] net/slirp: Tell the users when they are using deprecated options, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 02/17] qemu-doc: Do not promote deprecated -smb and -redir options, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 03/17] net: cadence_gem: check packet size in gem_recieve,
Jason Wang <=
- [Qemu-devel] [PULL 04/17] cadence_gem: fix buffer overflow, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 05/17] slirp: goto bad in udp_input if sosendto fails, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 06/17] slirp: Generalizing and neutralizing ARP code, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 07/17] slirp: Adding address family switch for produced frames, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 08/17] slirp: Make Socket structure IPv6 compatible, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 09/17] slirp: Factorizing address translation, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 10/17] slirp: Factorizing and cleaning solookup(), Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 11/17] slirp: Add sockaddr_equal, make solookup family-agnostic, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 12/17] slirp: Make udp_attach IPv6 compatible, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 13/17] slirp: Adding family argument to tcp_fconnect(), Jason Wang, 2016/02/01