[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on MIPS
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on MIPS |
Date: |
Tue, 2 Feb 2016 10:45:34 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 02/02/2016 10:26 AM, Peter Maydell wrote:
> On 2 February 2016 at 14:51, Eric Blake <address@hidden> wrote:
>> Commit 86f4b687 broke compilation on MIPS, which has a preprocessor
>> pollution of '#define mips 1'. Treat it the same way as we do for
>> the pollution with 'unix', so that QMP remains backwards compatible
>> and only the C code needs to use the alternative 'q_mips' spelling.
>>
>> CC: James Hogan <address@hidden>
>> Signed-off-by: Eric Blake <address@hidden>
>> ---
>> # namespace pollution:
>> - polluted_words = set(['unix', 'errno'])
>> + polluted_words = set(['unix', 'errno', 'mips'])
>> name = name.translate(c_name_trans)
>> if protect and (name in c89_words | c99_words | c11_words | gcc_words
>> | cpp_words | polluted_words):
>
> Looking at commit 86f4b687 I think we also need to add 'sparc' to the
> polluted_words list (Solaris defines that). I would also be unsurprised
> to find that some PPC platforms define 'ppc'. (Tricore is probably
> new enough to have escaped this namespace pollution and we don't
> support it as a host CPU anyway.)
Do we have anyone that can confirm on these platforms? Obviously, I
proved that it's fairly easy to work around, and I don't mind doing the
followup patch(es), but only if we have concrete cases where we know it
is needed.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature