Re: [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg DMA version

[Gerd Hoffmann]

  Hi,

> >> I agree that DMA capability should be filtered with machine type.
> >> However, that distinction should not be made using the current
> >> "dma_enabled" properties (i.e., of "fw_cfg_io_properties" and
> >> "fw_cfg_mem_properties". Instead, it should be made in the
> >> board-specific callers of fw_cfg_init_(io_dma|mem_wide).
> > 
> > Why?
> 
> That's how "has_reserved_memory" works as well, for example.

Those are machine options, not device options.  If we have a device
property there is no need to create a duplicate a machine option for the
same purpose.

> But, if the property is made work, I guess PC_COMPAT_2_4 can be used
> too. (Or should it be HW_COMPAT_2_4?)

HW_COMPAT_2_4 probably, so it applies to q35 too.

cheers,
  Gerd