qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/2] error: Documentation updates


From: Lluís Vilanova
Subject: Re: [Qemu-devel] [PATCH 0/2] error: Documentation updates
Date: Wed, 03 Feb 2016 20:17:34 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Markus Armbruster writes:

> This overlaps with parts of Lluís's "[RFC][PATCH v6 0/5] utils:
> Improve and document error reporting".  Lluís, feel free to integrate
> my patches into a respin of your series.  You can also respin on top
> of my series.

Reviewed-by: Lluís Vilanova <address@hidden>

I'm happy with this series as a replacement for mine. Two nitpicks:

* The error.h comments point to assert() instead of abort() as a replacement for
  error_setg(&error_abort) (while your HACKING says otherwise).

* HACKING does not explicitly point out that exit(1) is the preferred exit code.


Thanks,
  Lluis



reply via email to

[Prev in Thread] Current Thread [Next in Thread]