Re: [Qemu-devel] [PATCH 2/4] vfio: make the 4 bytes aligned for capability size

[Michael S. Tsirkin]

On Thu, Feb 04, 2016 at 09:31:06AM +0800, Cao jin wrote:
> From: Chen Fan <address@hidden>
> 
> this function search the capability from the end, the last
> size should 0x100 - pos, not 0xff - pos.
> 
> Signed-off-by: Chen Fan <address@hidden>
> Reviewed-by: Marcel Apfelbaum <address@hidden>

Reviewed-by: Michael S. Tsirkin <address@hidden>

> ---
>  hw/vfio/pci.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 49f3d2d..e671506 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -1505,7 +1505,8 @@ static void vfio_unmap_bars(VFIOPCIDevice *vdev)
>   */
>  static uint8_t vfio_std_cap_max_size(PCIDevice *pdev, uint8_t pos)
>  {
> -    uint8_t tmp, next = 0xff;
> +    uint8_t tmp;
> +    uint16_t next = PCI_CONFIG_SPACE_SIZE;
>  
>      for (tmp = pdev->config[PCI_CAPABILITY_LIST]; tmp;
>           tmp = pdev->config[tmp + 1]) {
> -- 
> 1.9.3
> 
>