|
| From: | Richard Henderson |
| Subject: | Re: [Qemu-devel] [PATCH v5 5/9] qemu-log: support simple pid substitution in logfile |
| Date: | Fri, 5 Feb 2016 09:26:36 +1100 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 02/05/2016 01:56 AM, Alex Bennée wrote:
+ if (g_strrstr(filename, "%d")) {
+ /* if we are going to format this we'd better validate first */
+ if (g_regex_match_simple("^[^%]+%d[^%]+$", filename, 0, 0)) {
Why g_strrstr instead of strstr? There should be only one, so why look for the last?
r~
| [Prev in Thread] | Current Thread | [Next in Thread] |