qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 9/9] cputlb: modernise the debug support


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v5 9/9] cputlb: modernise the debug support
Date: Fri, 5 Feb 2016 10:10:53 +1100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0

On 02/05/2016 01:56 AM, Alex Bennée wrote:
To avoid cluttering the code with #ifdef legs we wrap up the print
statements into a tlb_debug() macro. As access to the virtual TLB can
get quite heavy defining DEBUG_TLB_LOG will ensure all the logs go to
the qemu_log target of CPU_LOG_MMU instead of stderr. This remains
compile time optional as these debug statements haven't been considered
for usefulness for user visible logging.

I've also removed DEBUG_TLB_CHECK which wasn't used.

Signed-off-by: Alex Bennée<address@hidden>

---
v2
   - ensure compiler checks format strings even if debug is optimised out
v5
   - reword commit to justify not just using qemu_log at this time
---
  cputlb.c | 54 +++++++++++++++++++++++++++++++++++-------------------
  1 file changed, 35 insertions(+), 19 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]