Re: [Qemu-devel] [PATCH 2/2] ipmi_bmc_sim: Add break to correct watchdog NMI check

[Michael S. Tsirkin]

On Mon, Jan 11, 2016 at 07:32:32AM -0600, address@hidden wrote:
> From: Corey Minyard <address@hidden>
> 
> It was falling through when it should have been a break.  Found by
> Coverity.  The logic could be simplified a bit with a fallthrough,
> probably the original thought, but that would be less clear, I think.
> 
> Cc: Paolo Bonzini <address@hidden>
> Cc: Michael S. Tsirkin <address@hidden>
> Cc: Peter Maydell <address@hidden>
> Cc: Shannon Zhao <address@hidden>
> Cc: Xiao Guangrong <address@hidden>
> Cc: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Corey Minyard <address@hidden>

Reviewed-by: Michael S. Tsirkin <address@hidden>

> ---
>  hw/ipmi/ipmi_bmc_sim.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
> index 3ecf02e..e522ffa 100644
> --- a/hw/ipmi/ipmi_bmc_sim.c
> +++ b/hw/ipmi/ipmi_bmc_sim.c
> @@ -1101,6 +1101,8 @@ static void set_watchdog_timer(IPMIBmcSim *ibs,
>              rsp[2] = IPMI_CC_INVALID_DATA_FIELD;
>              goto out;
>          }
> +        break;
> +
>      default:
>          /* We don't support PRE_SMI */
>          rsp[2] = IPMI_CC_INVALID_DATA_FIELD;
> -- 
> 2.5.0