Re: [Qemu-devel] [PATCH 1/1] block: fix inability to start VM with native AIO

[Stefan Hajnoczi]

On Mon, Jan 11, 2016 at 05:26:19PM +0300, Denis V. Lunev wrote:
> On 01/11/2016 04:46 PM, Christian Borntraeger wrote:
> >On 12/22/2015 07:59 AM, Denis V. Lunev wrote:
> >>error: Failed to start domain rhel7
> >>error: internal error: process exited while connecting to monitor:
> >>     2015-12-22T06:55:18.812637Z qemu-system-x86_64:
> >>     -drive file=/var/lib/libvirt/images/rhel7.qcow2,if=none,
> >>         id=drive-scsi0-0-0-0,format=qcow2,cache=none,aio=native:
> >>     aio=native was specified, but it requires cache.direct=on,
> >>     which was not specified.
> >>
> >>cache=none option was specified as seen above while the VM is unable to
> >>start. The patch properly passed BDRV_O_NOCACHE to underlying layer.
> >>
> >>The problem is revealed with
> >>     commit d657c0c289e944fc22289f5c318f48da87d79dcb
> >>     Author: Kevin Wolf <address@hidden>
> >>     Date:   Tue Dec 15 11:35:36 2015 +0100
> >>
> >>         raw-posix: Make aio=native option binding
> >>
> >>Signed-off-by: Denis V. Lunev <address@hidden>
> >>CC: Kevin Wolf <address@hidden>
> >Acked-by: Christian Borntraeger <address@hidden>
> >
> >Without this patch all libvirt xmls with
> >cache='none' io='native'
> >are broken. We should apply this patch (or something else)
> >soon.
> >
> exactly!

For the record, the bug has been fixed.  I went back and bisected:

Kevin Wolf fixed the issue in "block: Fix .bdrv_open flags"
(82dc8b411040fa8a7418a012ff39b8d06f68e639).

Stefan

signature.asc
Description: PGP signature