[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/16] iothread: release AioContext around aio_p
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 05/16] iothread: release AioContext around aio_poll |
|
Date: |
Mon, 8 Feb 2016 16:34:16 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 05/02/2016 18:51, Stefan Hajnoczi wrote:
>> Because this is a file descriptor source, there is really no
>> difference between the code's behavior, no matter if aio_poll
>> starts before or after the event_notifier_set. The test passes
>> even if you remove the sleep.
>>
>> Do you have any suggestion? Just add a comment?
>
> How about removing the sleep and adding a comment explaining that
> the event_notifier_set() could happen either before or during
> poll()?
Okay.
Paolo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBCAAGBQJWuLV0AAoJEL/70l94x66DajUIAIddRKfy4S45hUQmz9XUTbhA
cWfq7SWKjRB7FQSTM2rGDgDCvxDA1MejaIgde3GEMYRQcOj3yZgS8oSvDLXR8Eny
Y71Ir/kyjbqVEgjnZwN/1g7gULoS/dZCI/rXgjFjxhe3TC9Pwp6Gp6d6+vlnWRWM
c0a1xSwXpbnfLthozgz4eHD7d0u77/Ph7WCyU/2VYI09xKnAel+sIELzrFUhOYcc
us4/6tYE1YT0ZagpLkVHXdWbJK30d8tqSU+tBCrW6L/Ql8TAUjwbufaYZpCFBBiL
lF1Aif4q3Bg3iCohq4gRSf+96gp2GpIowJKqIJg0BpT9Z5XI/xRRzUeIq9eLbMM=
=zN4i
-----END PGP SIGNATURE-----