qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel


From: John Snow
Subject: Re: [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@
Date: Mon, 8 Feb 2016 13:52:37 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0


On 02/08/2016 04:05 AM, Markus Armbruster wrote:
> Stephen Warren <address@hidden> writes:
> 
>> Add an entry to MAINTAINERS that matches every patch, and requests the
>> user send patches to address@hidden
>>
>> It's not 100% obvious to project newcomers that all patches should be sent
>> there; checkpatch doesn't say so, and since it mentions other lists to CC,
>> the wording "the list" from the SubmitAPatch wiki page can be taken
>> to mean only those lists, not the main list too.
>>
>> The F: entries were taken from a similar entry in the Linux kernel.
>>
>> Signed-off-by: Stephen Warren <address@hidden>
>> ---
>>  MAINTAINERS | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index b6ed87a26349..2d78eea5d62d 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -52,6 +52,11 @@ General Project Administration
>>  ------------------------------
>>  M: Peter Maydell <address@hidden>
>>  
>> +All patches CC here
>> +L: address@hidden
>> +F: *
>> +F: */
>> +
>>  Responsible Disclosure, Reporting Security Issues
>>  ------------------------------
>>  W: http://wiki.qemu.org/SecurityProcess
> 
> I acknowledge the problem, but your patch breaks the "No maintainers
> found, printing recent contributors" functionality.
> 
> Before:
> 
>     $ scripts/get_maintainer.pl -f MAINTAINERS 
>     get_maintainer.pl: No maintainers found, printing recent contributors.
>     get_maintainer.pl: Do not blindly cc: them on patches!  Use common sense.
> 
>     Paolo Bonzini <address@hidden> (commit_signer:20/74=27%)
>     Kevin Wolf <address@hidden> (commit_signer:13/74=18%)
>     Stefan Hajnoczi <address@hidden> (commit_signer:13/74=18%)
>     "Michael S. Tsirkin" <address@hidden> (commit_signer:10/74=14%)
>     Peter Maydell <address@hidden> (commit_signer:8/74=11%)
> 
> After:
> 
>     $ scripts/get_maintainer.pl -f MAINTAINERS 
>     address@hidden (open list:All patches CC here)
> 

Agree ... Might this also break any "unmaintained" scripts we use?

How about:
 1) Update the wiki to be clearer on the submission process, and
 2) Update the "no contributors found" output to also include the list
to send to?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]