[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] tests: Clean up includes
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] tests: Clean up includes |
Date: |
Mon, 8 Feb 2016 13:51:45 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 02/08/2016 11:49 AM, Peter Maydell wrote:
> Clean up includes so that osdep.h is included first and headers
> which it implies are not included manually.
>
> This commit was created with scripts/clean-includes.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> This deals with every .c file in tests/ except those
> in tests/tcg which I think are all standalone programs
> targeting the guest.
> ---
> 122 files changed, 122 insertions(+), 202 deletions(-)
You may want to wait for other maintainers to chime in for files they
care about; but I looked through the patch and nothing jumped out at me
as being incorrect. Many of the files already includes libqtest.c or
even osdep.h - for those files, the change is obviously correct.
Reviewed-by: Eric Blake <address@hidden>
Tested-by: Eric Blake <address@hidden>
> +++ b/tests/multiboot/libc.c
> @@ -20,6 +20,7 @@
> * THE SOFTWARE.
> */
>
> +#include "qemu/osdep.h"
> #include "libc.h"
>
> void* memcpy(void *dest, const void *src, int n)
Not so sure about this directory.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature